Modified samp element example and added a third one #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| detailed markup, to enable very precise styling. To achieve this, <code>span</code> elements are | ||
| used.</p> | ||
| <p>This second example shows a block of sample output from a console program. | ||
| Nested <code>samp</code> and <code>kbd</code> elements allow for the styling of specific elements |
There was a problem hiding this comment.
Nit: line wrapping is a bit off; e.g. I think you could fit Nested onto the previous line.
|
You forgot to add your name to the acknowledgments! :) This LGTM with some minor formatting nits that we can touch up while merging. I'll give it another day for other editors to review before merging. Thanks so much! (Note to self: add "fixes #1364" to the commit message while merging) |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.