Editorial: "allowed to show a popup" → "triggered by user activation" #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "allowed to show a popup" algorithm can be more generally useful than just in popup blocking. It should get a more general name so that it can be reused more broadly. This commit also moves it into the "Activation" section, instead of the "Browsing context names" section, as the former makes a lot more sense.
domenic
force-pushed
the
allowed-to-show-popup
branch
from
1d00849 to
35dc781
Compare
This was referenced May 31, 2016
|
Agreed (FWIW). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "allowed to show a popup" algorithm can be more generally useful
than just in popup blocking. It should get a more general name so that
it can be reused more broadly.
This commit also moves it into the "Activation" section, instead of the
"Browsing context names" section, as the former makes a lot more sense.
This is stage-setting for a follow-up PR that actually uses the concept, but I think it's a good change regardless, and I am pretty sure people have asked for it in the past. I can't find any open bugs though.