Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where the directionality of a <bdi> could be null. #10005

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix case where the directionality of a <bdi> could be null. #10005

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f19ed0d
Fix case where the directionality of a <bdi> could be null.
dbaron Dec 19, 2023
5c718be
Remove newlines per review comments from @annevk.
dbaron Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13599,19 +13599,24 @@ Transport Protocol">HTTP&lt;/abbr> today.&lt;/p></code></pre> <!-- DO NOT REWRAP

<dt><span data-x="attr-dir-undefined-state">undefined</span></dt>
<dd>
<ol>
<li><p>If <var>element</var> is a <code>bdi</code> element, then return the <span>auto
directionality</span> of <var>element</var>.</p></li>
<dl class="switch">
<dt>If <var>element</var> is a <code>bdi</code> element and the <span>auto
directionality</span> of <var>element</var> is not null</dt>

<li><p>If <var>element</var> is an <code>input</code> element whose <code
<dd><p>Return the <span>auto directionality</span> of <var>element</var>.</p></dd>

<dt>If <var>element</var> is an <code>input</code> element whose <code
data-x="attr-input-type">type</code> attribute is in the <span
data-x="attr-input-type-tel">Telephone</span> state, then return '<span
data-x="concept-ltr">ltr</span>'.</p></li>
data-x="attr-input-type-tel">Telephone</span> state</dt>

dbaron marked this conversation as resolved.
Show resolved Hide resolved
<dd><p>Return '<span data-x="concept-ltr">ltr</span>'.</p></dd>
<!-- This looks odd, but is very much deliberate:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=17835 -->

<li><p>Return the <span>parent directionality</span> of <var>element</var>.</p></li>
</ol>
<dt>Otherwise</dt>

dbaron marked this conversation as resolved.
Show resolved Hide resolved
<dd><p>Return the <span>parent directionality</span> of <var>element</var>.</p></dd>
</dl>
</dd>
</dl>

Expand Down