-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
focus delegate code seems wrongly only looking at children #8157
Labels
Comments
So should we look for |
Where exactly? "Get a focusable area" already deals with delegatesFocus so I think we don't need to do it twice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(Again, unless I'm missing something)
https://html.spec.whatwg.org/#focus-delegate says:
It only looks at children, but it seems to (in a note) think that "getting the focusable area" can end up recursing. Which is true, but afaict it only does if the child has
delegateFocus
, which seems wrong (see #8156).So I think this should look at all descendants in tree order, which combined with the fix for #8156 would give you the behavior we generally want / expect.
cc @sefeng211 @domenic
The text was updated successfully, but these errors were encountered: