Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
- Rename enable close watcher for requestClose()

- Add note to enable close watcher for request close
  • Loading branch information
lukewarlow committed Feb 25, 2025
1 parent 830339d commit 0b2bccb
Showing 1 changed file with 17 additions and 12 deletions.
29 changes: 17 additions & 12 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -62310,8 +62310,14 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
<p>Each <code>dialog</code> element has a <dfn>request close return value</dfn>, which is a
string, initially null.</p>

<p>Each <code>dialog</code> element has an <dfn>enable close watcher for <code
data-x="dom-dialog-requestClose">requestClose()</code></dfn> boolean, initially false.</p>
<p>Each <code>dialog</code> element has an <dfn>enable close watcher for request close</dfn>
boolean, initially false.</p>

<p class="note"><code>Dialog</code>'s <span>enable close watcher for request close</span> is used
to force enable the dialog's <span data-x="dialog-close-watcher">close watcher</span> while <span
data-x="dialog-request-close">requesting to close</span> it. A dialog whose <span>computed
closed-by state</span> is the <span data-x="attr-dialog-closedby-none-state">None</span> state
would otherwise have a disabled <span data-x="dialog-close-watcher">close watcher</span>.</p>

<p>Each <code>dialog</code> element has an <dfn>is modal</dfn> boolean, initially false.</p>

Expand Down Expand Up @@ -62458,9 +62464,8 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
value</span>.</p></li>

<li><p><i data-x="create-close-watcher-getEnabledState">getEnabledState</i> being to return
true if <var>dialog</var>'s <span>enable close watcher for <code
data-x="dom-dialog-requestClose">requestClose()</code></span> is true or <var>dialog</var>'s
<span>computed closed-by state</span> is not <span
true if <var>dialog</var>'s <span>enable close watcher for request close</span> is true or
<var>dialog</var>'s <span>computed closed-by state</span> is not <span
data-x="attr-dialog-closedby-none-state">None</span>; otherwise false.</p></li>
</ul>
</li>
Expand All @@ -62472,7 +62477,7 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
<ol>
<li><p>If <var>command</var> is in the <span
data-x="attr-button-command-close-state">Close</span> state, <span
data-x="attr-button-command-request-close-state">Request Close</span> state or the <span
data-x="attr-button-command-request-close-state">Request Close</span> state, or the <span
data-x="attr-button-command-show-modal-state">Show Modal</span> state, then return true.</p></li>

<li><p>Return false.</p></li>
Expand Down Expand Up @@ -62500,8 +62505,8 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {

<li>
<p>If <var>command</var> is in the <span
data-x="attr-button-command-request-close-state">Close</span> state and <var>element</var> has
an <code data-x="attr-dialog-open">open</code> attribute:</p>
data-x="attr-button-command-request-close-state">Request Close</span> state and
<var>element</var> has an <code data-x="attr-dialog-open">open</code> attribute:</p>

<ol>
<li><p>Let <var>value</var> be <var>invoker</var>'s <span
Expand Down Expand Up @@ -62624,8 +62629,8 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
<li><p><span>Assert</span>: <span>this</span>'s <span data-x="dialog-close-watcher">close
watcher</span> is not null.</p></li>

<li><p>Set <var>dialog</var>'s <span>enable close watcher for <code
data-x="dom-dialog-requestClose">requestClose()</code></span> to true.</p></li>
<li><p>Set <var>dialog</var>'s <span>enable close watcher for request close</span> to
true.</p></li>

<li><p>If <var>returnValue</var> is not given, then set it to null.</p></li>

Expand All @@ -62635,8 +62640,8 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
<li><p><span data-x="close-watcher-request-close">Request to close</span> <var>dialog</var>'s
<span data-x="dialog-close-watcher">close watcher</span> with false.</p></li>

<li><p>Set <var>dialog</var>'s <span>enable close watcher for <code
data-x="dom-dialog-requestClose">requestClose()</code></span> to false.</p></li>
<li><p>Set <var>dialog</var>'s <span>enable close watcher for request close</span> to
false.</p></li>
</ol>

</div>
Expand Down

0 comments on commit 0b2bccb

Please sign in to comment.