Associate service worker timing with a response #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
May 3, 2021
fetch.bs
Outdated
| @@ -1973,6 +1973,10 @@ this is also tracked internally using the request's <a for=request>timing allow | |||
| <dfn for=response id=concept-response-timing-info>timing info</dfn> (null or a | |||
| <a for=/>fetch timing info</a>), which is initially null. | |||
|
|
|||
| <p>A <a for=/>response</a> has an associated | |||
| <dfn export for=response id=concept-response-service-worker-timing-info>service worker timing</dfn> (null or a | |||
There was a problem hiding this comment.
Also no need for the ID here and I wonder if we should name this field "service worker timing info" for consistency with "timing info".
|
It would also be good to have a commit message that links the two service worker PRs to make it clear this is part of a larger whole. |
In preparation for w3c/ServiceWorker#1575 and w3c/navigation-timing#143 This will allow exposing the service worker timing as part of the Navigation Timing API.
noamr
force-pushed
the
service-worker-timing
branch
from
0e3dba2 to
7e4df85
Compare
|
@noamr I still think we should name fields on response with some consistency. |
Ah I see I missed a comment. |
annevk
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preperation for w3c/ServiceWorker#1575 and w3c/navigation-timing#143, the response has to have an associated service worker timing. This would only affect navigation timing, where the actual start/ready timing of the service worker is a meaningful metric.
Preview | Diff