Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "append" instead of "set" to modify the header list #758

Closed
annevk opened this issue Jun 6, 2018 · 0 comments
Closed

Use "append" instead of "set" to modify the header list #758

annevk opened this issue Jun 6, 2018 · 0 comments
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@annevk
Copy link
Member

annevk commented Jun 6, 2018

Per @youennf at #747 (comment) Fetch uses "set" in three places (CORS-preflight fetch, Response.redirect()) where it could use "append" instead.

It seems worth using "append" consistently.
@annevk annevk added good first issue Ideal for someone new to a WHATWG standard or software project clarification Standard could be clearer labels Jun 6, 2018
ryzokuken added a commit to ryzokuken/fetch that referenced this issue Sep 10, 2018
@ryzokuken
Editorial: Use "append" to modify the header list
830c581 
Use "append" instead of "set" to modify the header list, improving
consistency (whatwg#758).
@ryzokuken ryzokuken mentioned this issue Sep 10, 2018
Merged
ryzokuken added a commit to ryzokuken/fetch that referenced this issue Sep 10, 2018
@ryzokuken
Editorial: Use "append" to modify the header list
2bd2f6b 
Use "append" instead of "set" to modify the header list, improving
consistency (whatwg#758).
@annevk annevk closed this as completed in daca6a8 Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annevk