-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimizing Browser Window #341
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soumyashaw minimizing browser window should be in every option. currently by this PR it will minimize the browser in chatting only.
Should I remove the whitespaces? |
@soumyashaw Remove whitespaces and resolve the conflicts |
I don't understand the change needed. Could you give some insight @rpotter12 |
To make code easily readable we follow some basic rules to write a good code like we use PEP8 to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soumyashaw Instead of adding same code in each file, create a function in browser_config.py file and add the code in that function and call that function in each file.
Adding same type of code in each decreases the code quality.
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- wplay/terminal_chat.py 1
See the complete overview on Codacy |
The changes you suggested are done. |
@soumyashaw I need to test it first. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soumyashaw win32gui
and win32con
are only compatible with windows. Try to find the solution which can be executable in all the platforms.
This is not a good approach, in addition to being for windows only adds additional libraries. Pyppeteer has an option to hide the browser, the "headless" parameter must be set in this function below. Changes in the session manager will also be necessary, since it is necessary to show the browser when the user is not logged in. |
I saw that part in Pyppeteer and that's why didn't use that as it won't serve the purpose. |
@soumyashaw Implement that solution which can be run in all platform. |
Issue that this pull request solves
Closes: #295
Proposed changes
Minimizes the Browser window for Terminal Chat mode
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyOther information
Tested the working on my system (Windows)