Stop using proc-macro-hack #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this may be an pseudo-internal API-break between |
|
@whatisaphone any chance this could be merged? |
|
@whatisaphone I'm happy to help any way I can... The change looks good to me at a quick glance. |
|
Btw this is also causing trouble for people using rust-analyzer; see rust-lang/rust-analyzer#6835 (comment) — so would be great to merge this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.45 enabled native support for
#[proc_macro]in expression position, which supersedesproc-macro-hackas noted itself. However, since the decl macros ingenawaiter-macroare calling proc macros ingenawaiter-proc-macro, the token fix in rust-lang/rust#73293 is also needed for captured value hygiene, which was first innightly-2020-06-25and released in 1.46.