-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import rework #59
Import rework #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wallaby and vitest are failing when I try it (after pnpm i). Does it work for you?
I get:
Tests 3 failed | 330 passed | 4 skipped (337)
awesome to see the import cases all passing |
I'm surprised there aren't new import cases despite some spec changes, etc. Don't hold those corner cases in! add some cases while imports are relatively fresh in your mind? we'll use 'em a lot and for other tools too. (obviously can be separate commit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests need to pass of course. Otherwise fix or defer minor comments and lgtm.
Apparently running vitest from the root is still broken for me
Which tests fail for you? For me, Aah, |
This is ready to merge. While the spec has changed, it hasn't changed in a significant enough way to actually impact this. (I'll update the import parser to look 100% like the spec in a future PR) |
I'm merging this |
Reworks the imports grammar and types