Address some todos

wgsl-tooling-wg · Feb 8, 2025 · b27c96d · mighdoll · Feb 8, 2025 · b27c96d
1 parent 07c6c25
commit b27c96d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/linker/packages/bench/bin/bench.ts b/linker/packages/bench/bin/bench.ts
@@ -80,7 +80,7 @@ function runBench(variant: ParserVariant, file: LoadedFile): number {
   const warmupIterations = 5;
   const benchIterations = 20;
 
-  // TODO try e.g. TinyBench instead
+  // TODO Use Deno.bench instead
 
   /* warmup */
   runNTimes(warmupIterations, variant, file);

diff --git a/linker/packages/linker/src/AbstractElems.ts b/linker/packages/linker/src/AbstractElems.ts
@@ -161,7 +161,7 @@ export interface ParenthesizedExpression extends AbstractElemBase {
 }
 export interface ComponentExpression extends AbstractElemBase {
   kind: "component-expression";
-  // TODO: How do I safely type this? As in, I want "first comes the name, then the component"
+  // To safely type this, don't use contents, but rather define your own props!
   contents: [ExpressionElem, ExpressionElem];
 }
 // TODO: We will emit these very soon (for the @if(expr))

diff --git a/linker/packages/linker/src/BindIdents.ts b/linker/packages/linker/src/BindIdents.ts
@@ -208,8 +208,7 @@ function findExport(
   modulePathParts: string[],
   parsed: ParsedRegistry,
 ): DeclIdent | undefined {
-  const legacyConvert = modulePathParts.map(p => (p === "." ? "package" : p)); // TODO rm after we update grammar
-  const modulePath = legacyConvert.slice(0, -1).join("::");
+  const modulePath = modulePathParts.slice(0, -1).join("::");
   const module = parsed.modules[modulePath];
   if (!module) {
     // TODO show error with source location