-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementing JWT for rest api #1134
Conversation
Great! I would leave the older login endpoints for the moment, there are probably other people that are using them, but should add some deprecation warning to the docs. Could you add some kind of usage for this? We can basically use the same ones from their docs https://django-rest-framework-simplejwt.readthedocs.io/en/latest/getting_started.html#usage |
@rolandgeider Can you specify where I would add the usage for jwt endpoints ? |
The api docs are in |
@rolandgeider docs added |
great, I will try to test this today or tomorrow |
This looks great thanks. We're very close to releasing these next days so would wait to merging this since it is a rather important change. The PR is approved so it counts towards hacktoberfest (and I'll merge it next week or so when we've released anyway) |
Cool 👍 My hacktoberfest task is already completed though 😃. |
Proposed Changes
Please check that the PR fulfills these requirements
Other questions
(e.g. database migration)?
No