This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As netty 4 API has been fixed now, I made lettuce working with netty 4.0.4.Final.
This passes all 219 tests with no complaints, in Mac OS X 10.8.4 / Java 1.7.0_11.
Aside from find-and-replace changes, there are a few changes like
ChannelInitializer
instead ofChannelPipelineFactory
and simplifiedConnectionWatchdog.run()
@ChannelHandler.Sharable
annotation to eachChannelHandler
classes, to make the multiplicity checker happy during reconnectionCommand.output != null
checks to safely ignore responses from timed out commands. This makes theClientTask.timeout()
the happyPlease review the changes and I'd be happy to have it merged to your repository, or possibly in a separate branch for netty 4.
Many thanks for making this awesome library!