Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

migrated to netty 4.0.4 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

migrated to netty 4.0.4 #21

wants to merge 1 commit into from

Conversation

jongwook
Copy link

As netty 4 API has been fixed now, I made lettuce working with netty 4.0.4.Final.

This passes all 219 tests with no complaints, in Mac OS X 10.8.4 / Java 1.7.0_11.

Aside from find-and-replace changes, there are a few changes like

  • ChannelInitializer instead of ChannelPipelineFactory and simplified ConnectionWatchdog.run()
  • @ChannelHandler.Sharable annotation to each ChannelHandler classes, to make the multiplicity checker happy during reconnection
  • Manually releasing ByteBuf, as netty 4 requires it, as well as manual HashedWheelTimer stopping
  • Command.output != null checks to safely ignore responses from timed out commands. This makes the ClientTask.timeout() the happy

Please review the changes and I'd be happy to have it merged to your repository, or possibly in a separate branch for netty 4.

Many thanks for making this awesome library!

@jongwook jongwook mentioned this pull request Jul 29, 2013
@wg
Copy link
Owner

wg commented Jul 29, 2013

Thanks for the pull request @jongwook! I have already done some preliminary netty 4 migration work on a private branch and won't be merging this request, but will use it as a reference. Thank you!

@ninowalker
Copy link

It seems this is still pending. Is there a netty 4.0.x version still in the works?

@kichik
Copy link

kichik commented Jan 31, 2015

@ninowalker you can use the following fork for Netty 4 support.
It is still under active development and accepts pull requests.
https://github.com/mp911de/lettuce/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants