Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20220517-zrq-user-accounts - all the changes in one big commit #712

Merged
merged 3 commits into from
May 18, 2022
Merged

20220517-zrq-user-accounts - all the changes in one big commit #712

merged 3 commits into from
May 18, 2022

Conversation

Zarquan
Copy link
Collaborator

@Zarquan Zarquan commented May 17, 2022 •
edited
Loading

This branch replaces 20220505 zrq user accounts (#713 ).
I created a new clean branch from master and used meld to add all the changes #713 into one big commit.

@Zarquan Zarquan requested a review from stvoutsin May 17, 2022 15:27
@Zarquan Zarquan mentioned this pull request May 18, 2022
Closed
@Zarquan Zarquan changed the title Top level create user scripts, reading from YAML and writing JSON 20220517-zrq-user-accounts - all the changes in one big commit May 18, 2022
stvoutsin
stvoutsin approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@stvoutsin stvoutsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only comment is that the create_unix_user.sh script expects to find "id_rsa" as the Zeppelin user's ssh keyname, but in some of the instances the key name is set to "id_ssh_rsa"

@stvoutsin stvoutsin merged commit 519febe into wfau:master May 18, 2022
@Zarquan Zarquan deleted the 20220517-zrq-user-accounts branch May 19, 2022 11:21
This was referenced May 27, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stvoutsin stvoutsin stvoutsin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zarquan @stvoutsin