Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a github workflow, that runs yamllint on our deployment scripts #615

Merged
merged 8 commits into from
Jan 12, 2022

Conversation

stvoutsin
Copy link
Collaborator

No description provided.

@Zarquan Zarquan self-requested a review January 10, 2022 06:32
@Zarquan
Copy link
Collaborator

Zarquan commented Jan 10, 2022

Can we rename the yamllint config file so that it is not hidden. yamllint.yml is fine, just remove the '.'.
General rule, we should not have any hidden files checked in to git.

@Zarquan
Copy link
Collaborator

Zarquan commented Jan 10, 2022

I'd like to keep the extra spaces after colons. Disabling the max-spaces-after rule should do it.

rules:
  colons:
    max-spaces-before: 0
    max-spaces-after: -1

@Zarquan
Copy link
Collaborator

Zarquan commented Jan 10, 2022

If this works, should we promote it to the top level of the whole project ? Possibly leave as-is for this PR, test it out and then apply it to everything in a separate PR.

@stvoutsin
Copy link
Collaborator Author

Can we rename the yamllint config file so that it is not hidden. yamllint.yml is fine, just remove the '.'. General rule, we should not have any hidden files checked in to git.

I've renamed the file in recent commit 186941a
and
186941a
(There was a typo in the first commit)

@stvoutsin
Copy link
Collaborator Author

If this works, should we promote it to the top level of the whole project ? Possibly leave as-is for this PR, test it out and then apply it to everything in a separate PR.

We probbably should at some point, though when I ran it the first time it produced several errors, so there would be lots of cleaning up to do.

@stvoutsin
Copy link
Collaborator Author

I'd like to keep the extra spaces after colons. Disabling the max-spaces-after rule should do it.

rules:
  colons:
    max-spaces-before: 0
    max-spaces-after: -1

Ok this has been changed in commit: df8326b

Copy link
Collaborator

@Zarquan Zarquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. We should look to do more of this.

@Zarquan Zarquan merged commit 8703be5 into wfau:master Jan 12, 2022
@stvoutsin stvoutsin deleted the issue/gh-workflow branch June 3, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants