Change Exec command in desktop file to wezterm start --
#2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! What do you think about also adding in something like |
|
I was able to replicate the problem with Dolphin in #2103 and I appear to have fixed it by setting the |
wez
added a commit
that referenced
this pull request
Jul 17, 2022
|
Thanks! |
|
FYI I think this commit broke For example when From a quick glance at the XDG spec it looks like it isn't a wezterm bug though, the Edit: Nevermind, it was a KDE issue and fixed in KDE/kio@ad27f0e |
vimpostor
added a commit
to vimpostor/wezterm
that referenced
this pull request
Oct 26, 2022
In a56904e the desktop file was patched to use "wezterm start" instead of "wezterm". As an unneeded addendum that patch also included the unnecessary addition of ending command-line parsing by passing the "--" option at the end. As it turns out, some consumers of wezterm's desktop file want wezterm to parse command line flags. For example KDE's kio passes the whole cmdline via the "-e" flag, because it is widely used for most terminal emulators as the primary mean of passing the cmdline. To solve this we remove the unneeded "--" again, because we now also support the "-e" option. After all, all trailing arguments will automatically be parsed by wezterm as the cmdline of the program to run. The only sideeffect of this change is that we now cannot longer start programs that share a name with a "wezterm start" option, for example if the user has installed an executable at /usr/bin/--always-new-process then this edge case will not work anymore. Given that this would be an extremely unlikely scenario, it makes more sense to improve compatibility by supporting the usecase of passing the cmdline with the "-e" flag. refs: wez#2622 refs: wez#2271 refs: https://bugs.kde.org/show_bug.cgi?id=459616
vimpostor
added a commit
to vimpostor/wezterm
that referenced
this pull request
Nov 2, 2022
In a56904e the desktop file was patched to use "wezterm start" instead of "wezterm". As an unneeded addendum that patch also included the unnecessary addition of ending command-line parsing by passing the "--" option at the end. As it turns out, some consumers of wezterm's desktop file want wezterm to parse command line flags. For example KDE's kio passes the whole cmdline via the "-e" flag, because it is widely used for most terminal emulators as the primary mean of passing the cmdline. To solve this we remove the unneeded "--" again, because we now also support the "-e" option. After all, all trailing arguments will automatically be parsed by wezterm as the cmdline of the program to run. The only sideeffect of this change is that we now cannot longer start programs that share a name with a "wezterm start" option, for example if the user has installed an executable at /usr/bin/--always-new-process then this edge case will not work anymore. Given that this would be an extremely unlikely scenario, it makes more sense to improve compatibility by supporting the usecase of passing the cmdline with the "-e" flag. refs: wez#2622 refs: wez#2271 refs: https://bugs.kde.org/show_bug.cgi?id=459616
wez
pushed a commit
that referenced
this pull request
Nov 4, 2022
In a56904e the desktop file was patched to use "wezterm start" instead of "wezterm". As an unneeded addendum that patch also included the unnecessary addition of ending command-line parsing by passing the "--" option at the end. As it turns out, some consumers of wezterm's desktop file want wezterm to parse command line flags. For example KDE's kio passes the whole cmdline via the "-e" flag, because it is widely used for most terminal emulators as the primary mean of passing the cmdline. To solve this we remove the unneeded "--" again, because we now also support the "-e" option. After all, all trailing arguments will automatically be parsed by wezterm as the cmdline of the program to run. The only sideeffect of this change is that we now cannot longer start programs that share a name with a "wezterm start" option, for example if the user has installed an executable at /usr/bin/--always-new-process then this edge case will not work anymore. Given that this would be an extremely unlikely scenario, it makes more sense to improve compatibility by supporting the usecase of passing the cmdline with the "-e" flag. refs: #2622 refs: #2271 refs: https://bugs.kde.org/show_bug.cgi?id=459616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems rely on the default terminal emulator's desktop entry for things like launching terminal applications with an application launcher or having a resource opener open a file with a terminal application. Currently, setting WezTerm as the default terminal emulator without overriding its desktop file breaks functionality like this because its desktop entry uses
wezterminstead ofwezterm startin itsExecfield, which just terminates with an error when it is passed a command to run.