Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal not closing on exit if job has been launched. #839

Closed
brymko opened this issue Jun 1, 2021 · 1 comment
Closed

Terminal not closing on exit if job has been launched. #839

brymko opened this issue Jun 1, 2021 · 1 comment
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. Linux Issue applies to Linux

Comments

@brymko
Copy link

brymko commented Jun 1, 2021

Describe the bug

brymko@Arch ~$ alias binja
binja='/home/brymko/ctf/binaryninja/binaryninja &; disown; exit'
brymko@Arch ~$ binja
[1] 2090877

blab lbla
no closing




Environment (please complete the following information):

  • Linux X11
  • Version: wezterm 20210531-084019-1a442555
  • US ANSI

To Reproduce

run command as job which does not terminate right away, for instance yes > /dev/null &; disown; exit. Notice that the terminal will stay open until yes has exited.

Configuration

local wezterm = require 'wezterm';

return {
    -- FONTS
    font_size = 9.0;
    
    -- TODO: fallback fonts yo.
    -- sudo pacman -S fft-fira-mono
    font = wezterm.font('Fira Mono Medium', {bold = false, italic=false});

    -- KEYS
    use_dead_keys = false;
    disable_default_key_bindings = true;
    keys = {
        { key = "c", mods = "CTRL|SHIFT", action=wezterm.action{ CopyTo = "ClipboardAndPrimarySelection" }},
        { key = "v", mods = "CTRL|SHIFT", action=wezterm.action{ PasteFrom = "Clipboard" }},
        { key = "+", mods = "CTRL", action = "IncreaseFontSize" },
        { key = "-", mods = "CTRL", action = "DecreaseFontSize" },
        { key = "=", mods = "CTRL", action = "ResetFontSize" },
        { key = "j", mods = "CTRL|ALT", action = wezterm.action{ScrollByLine=5}},
        { key = "k", mods = "CTRL|ALT", action = wezterm.action{ScrollByLine=-5}},
        { key = "f", mods = "CTRL", action = wezterm.action{Search={Regex=""}}},
        { key = "m", mods = "CTRL|ALT", action = "ActivateCopyMode" },
    };

    -- shit i already have i3 for
    hide_tab_bar_if_only_one_tab = true;
    window_close_confirmation = "NeverPrompt";

    -- Scrollback
    scrollback_lines = 10000;
    enable_scroll_bar = false;

    -- no hyperlinks
    hyperlink_rules = {
        {
            regex = "",
            format ="$0",
        },
    };
      
}

Expected behavior

Terminal should close on exit.

@brymko brymko added the bug Something isn't working label Jun 1, 2021
@wez wez added the Linux Issue applies to Linux label Jun 1, 2021
wez added a commit that referenced this issue Jun 1, 2021
Expand on the changes in 3f6ff53,
this makes them more general and so that they can be used on unix
systems.

That in turn helps to tackle #839,
wherein `sleep 300 & disown ; exit` would linger until EOF is detected,
rather than triggering as soon as the child process terminated.

For whatever reason, that would only manifest on linux (and not macos).
wez added a commit that referenced this issue Jun 1, 2021
@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Jun 1, 2021
@wez wez closed this as completed in db9a65a Jun 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. Linux Issue applies to Linux
Projects
None yet
Development

No branches or pull requests

2 participants