Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable font does not work with Bold #655

Closed
gwww opened this issue Apr 6, 2021 · 2 comments
Closed

Variable font does not work with Bold #655

gwww opened this issue Apr 6, 2021 · 2 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@gwww
Copy link
Contributor

gwww commented Apr 6, 2021

Describe the bug

When using a variable font bold does not work.

Environment (please complete the following information):

  • OS: macOS 11.1
  • Version: 20210405-110924-a5bb5be8-4-gd2419fb9

To Reproduce

Using the Inconsolata font from here: https://fonts.google.com/specimen/Inconsolata, the variable font (single font file with all the widths and weights) does not show bold.

Using the static versions of the regular and bold (installing two files, the regular and the bold) does work.

Configuration

return { font=wezterm.font("Inconsolata")

Other

See discussion in #648

@gwww gwww added the bug Something isn't working label Apr 6, 2021
wez added a commit that referenced this issue Apr 8, 2021
With this configuration:

```lua
local wezterm = require 'wezterm'

return {
  font_dirs = {"/Users/wez/Downloads/Inconsolata"},
  font = wezterm.font("Inconsolata"),
  font_locator = "ConfigDirsOnly"
}
```

wezterm is now able to see the 74 variations that are available
in the single inconsolata ttf.

Running `WEZTERM_LOG=wezterm_font=trace wezterm` will log the
variations.

refs: #655
wez added a commit that referenced this issue Apr 8, 2021
wez added a commit that referenced this issue Apr 8, 2021
wez added a commit that referenced this issue Apr 8, 2021
wez added a commit that referenced this issue Apr 8, 2021
wez added a commit that referenced this issue Apr 8, 2021
and remove the old one

refs: #655
wez added a commit that referenced this issue Apr 8, 2021
@gwww
Copy link
Contributor Author

gwww commented Apr 9, 2021

This is fixed for me. Tested in nightly.

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Apr 9, 2021
@wez wez closed this as completed Apr 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

2 participants