wayland: fullscreen/maximized state broken under mutter

[jeromegn]

Describe the bug

When trying to toggle fullscreen on WezTerm (by dragging the window to the top of the screen, on Gnome), the window gets the right width and height, but it's not "clamped" like other fullscreen windows.

Environment (please complete the following information):

• OS: Linux Wayland
• Version: wezterm 20200608-110940-3fb3a61

To Reproduce

Drag window to top of the screen to toggle fullscreen

Configuration

(doubt this is relevant)

local wezterm = require 'wezterm';
return {
  font = wezterm.font("JetBrains Mono"),
  color_scheme = "Dracula",
  enable_wayland = true,
  default_cursor_style = "SteadyBar",
}

Expected behavior

It should use the whole screen and be clamped to all edges.

Screenshots

[wez]

We use https://github.com/smithay/client-toolkit for the wayland client window handling.
mutter (the wayland compositor used by gnome) and the client toolkit tickle
problems with each other's implementation; the last similar issue was actually
a bug in mutter exposed by the client toolkit Smithay/client-toolkit#92 https://gitlab.gnome.org/GNOME/mutter/issues/1024

You can work around this issue by setting enable_wayland = false in your config.

Next steps:

• Someone should probably report this to both smithay-client and mutter
• It's worth thinking about how much effort it would be to remove this dep in the hope that we don't see this class of issue again

[jeromegn]

Interesting. That makes sense.

enable_wayland = false doesn't appear to help though.

[wez]

You need to restart wezterm for that particular config to take effect; the choice of window system is global and processed only at startup!

[jeromegn]

Even with a restart. This is odd. Any way to confirm the settings are applied?

[wez]

It should be fairly apparent if it has taken effect, as the title bar will render differently when falling back to X.

I'd suggest launching wezterm from a different terminal for debugging purposes;

RUST_LOG=trace wezterm 2>/tmp/verbose.txt

and attach /tmp/verbose.txt to this issue.

[jeromegn]

My bad, I had 2x enable_wayland and they conflicted.

Fullscreen does work with X11.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.