Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Umlauts and other non-ascii chars in output #1

Closed
mborejdo opened this issue May 22, 2020 · 4 comments
Closed

Broken Umlauts and other non-ascii chars in output #1

mborejdo opened this issue May 22, 2020 · 4 comments

Comments

@mborejdo
Copy link

Describe the bug

running eledo.exe [programname] shows UAC and runs program, but shows "broken" line-drawing characters, umlauts, etc

Environment

OS: Microsoft Windows [Version 10.0.19041.264]
Term: wezterm 20200517-122836-92c201c6-6-g7ddff705

To Reproduce

Run whoami /groups on German Windows

Expected behavior

Captured program output is displayed correctly

wez added a commit that referenced this issue May 22, 2020
I'm skeptical that this will help, but it at least makes things
explicit; this commit adds a manifest that sets these utilities
into UTF-8 mode, and the bridge process will force the PTY console
into UTF-8 mode also.

That should make most of the pipeline UTF-8 everything.
However, we can't force the hosting console of `normdo` or `eledo`
into UTF-8 mode (well, we can, but we don't own it, so we shouldn't!).

This may help with refs: #1
@wez
Copy link
Owner

wez commented May 22, 2020

I pushed a commit that may help, but I'm not totally convinced--it feels too easy :-p

I think microsoft/terminal#4551 may be related.

Is your system set to use a German code page rather than UTF-8? (I'm not asking you to change anything, just want to understand the environment)

@mborejdo
Copy link
Author

Unfortunately the fix does not solve the problem.

chcp shows
Aktive Codepage: 850.

wez added a commit that referenced this issue May 22, 2020
refs: #1

This seems to work for me if I do:

```
chcp 850
.\target\debug\normdo.exe cmd
```

and then type some text with umlauts and `type` a file containing
utf-8.
@wez
Copy link
Owner

wez commented May 22, 2020

I think I may have it resolved in the latest commit; it seems to work locally when I try changing my code page to 850 and do some simple input/output experiments.

@mborejdo
Copy link
Author

mborejdo commented May 22, 2020

I can confirm my umlauts work again :-) The last commit fixes the problem. Thank you very much!

@wez wez closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants