Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #228, use custom documentation rules #266

Merged
merged 1 commit into from
May 15, 2019

Conversation

pderaaij
Copy link
Contributor

No description provided.

@pderaaij
Copy link
Contributor Author

@smythey21 Same for this one.

@ThomasPr
Copy link

This pull request builds the final URL like that:
${rule.url}#${rule.name}

I prefer to define the rule url independently from the rule name.
One might link to a page or an anchor that is named differently from the rule name.

@pderaaij pderaaij force-pushed the custom-documentation-urls branch from 533fa83 to 90547a9 Compare May 14, 2019 07:35
@pderaaij
Copy link
Contributor Author

@djtarazona Fixed this one

@djtarazona djtarazona merged commit 653ed1b into wework:master May 15, 2019
@pderaaij pderaaij deleted the custom-documentation-urls branch May 22, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants