-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect verbosity levels #265
Conversation
@smythey21 Can you have a look at this? Can't add you as a reviewer |
@smythey21 unfortunately I can't merge pull requests as I don't have write access. Can you press the button? |
@mdaloia Thanks, wasn't aware of the default value argument. Changed it. |
@pderaaij You're welcome! I have one doubt. Maybe I'm not seeing something but, aren't you now ignoring the Based on your original modification: const verbose = config.get('quiet') ? 0 : (config.get('verbose') ? config.get('verbose') : 1); what I had in mind about was to change it to something like this: const verbose = config.get('quiet') ? 0 : config.get('verbose', 1); |
I should not code before I have my first coffee. Fixed, thanks |
@djtarazona Can you have a look at this PR and merge? |
@pderaaij I will review this weekend. Sorry for the delay! |
@djtarazona No problem, let me know how I can help work away the open Pull Requests... |
@djtarazona or @smythey21 any update? |
@pderaaij Sorry, I will merge as soon as I get some permission issues for this repo sorted out. |
Ensures that verbosity levels are respected and passed on to dependent modules.