Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support options before and after command #229

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Conversation

philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented Dec 18, 2018

Fixes #217 and #221, where a false positive "no arguments passed" check in speccy.js was causing the help page to show up, even when arguments were passed.

Now both speccy lint -j foo.yaml and speccy lint foo.yaml -j will both work as expected. Previously only the latter was supported.

@coveralls
Copy link

coveralls commented Dec 18, 2018

Coverage Status

Coverage remained the same at 87.817% when pulling 0818cd2 on fix/argument-order into cb361c9 on master.

CommandJS advertises both are available, but we were getting a false positive from  when deciding if we should show the help page or not.
@philsturgeon philsturgeon requested a review from swirsky December 18, 2018 17:50
@philsturgeon philsturgeon merged commit 3a7a87e into master Dec 18, 2018
@philsturgeon philsturgeon deleted the fix/argument-order branch December 18, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants