notEndWith should not trigger on 1 char strings #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because its not just ending with that, but starting with that. Fixes #134
philsturgeon
changed the title
philsturgeon
commented
Aug 14, 2018
| @@ -66,9 +66,11 @@ describe('Linter', () => { | |||
| getLinterErrors(runLinter('something', input, args.key)).should.be.deepEqual(expectedErrors); | |||
| } | |||
|
|
|||
| const lintAndExpectValid = async (rule, input, args = {}) => { | |||
There was a problem hiding this comment.
No need to have this function be async, and it was making failures show up as unhandled promise warnings (false green on test suite)
nesl247
approved these changes
Aug 14, 2018
swirsky
approved these changes
Aug 15, 2018
|
@philsturgeon Any chance to get a release for this? I can't upgrade to 0.8 until then. Thanks! |
|
I’m currently in a field for WeWork Summer Camp, but I’ll get that done on Monday.
—
Phil Sturgeon
… On Aug 16, 2018, at 20:33, Harrison Heck ***@***.***> wrote:
@philsturgeon Any chance to get a release for this? I can't upgrade to 0.8 until then. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because its not just ending with that, but starting with that.
Fixes #134