Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong mapping of JSON RPC method for watchAsset #934

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

sebasyii
Copy link
Contributor

@sebasyii sebasyii commented Jul 25, 2023

The docs stated the JSON RPC method was eth_switchEthereumChain but it should be wallet_watchAsset.


PR-Codex overview

This PR focuses on renaming the JSON-RPC method eth_switchEthereumChain to wallet_watchAsset.

Detailed summary

  • Renamed eth_switchEthereumChain JSON-RPC method to wallet_watchAsset.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

The docs stated the JSON RPC method was `eth_switchEthereumChain` but it should be `wallet_watchAsset`.
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

⚠️ No Changeset found

Latest commit: 8fa9e4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 25, 2023

@sebasyii is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom merged commit a01d42f into wevm:main Jul 25, 2023
aaronmgdr pushed a commit to celo-org/viem that referenced this pull request Aug 18, 2023
fix: wrong mapping of JSON RPC method for watchAsset

The docs stated the JSON RPC method was `eth_switchEthereumChain` but it should be `wallet_watchAsset`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants