-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(EIP712
): chainId
should support uint256
values
#257
Conversation
🦋 Changeset detectedLatest commit: 0ba2288 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chainId
should support uint256
valueschainId
should support uint256
values
chainId
should support uint256
valuesEIP712
): chainId
should support uint256
values
59ae8ba
to
e5cdc14
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 26 26
Lines 6103 6103
Branches 196 186 -10
=======================================
Hits 6094 6094
Misses 8 8
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Since the largest integer that a
number
could safely represent in TypeScript is 2^53 - 1, bigger values that are supported byuint256
cannot fit into it (some sample values in the issue).Closes #256
PR-Codex overview
This PR focuses on updating the
TypedDataDomain
type to allow thechainId
property to acceptbigint
values in addition tonumber
, enhancing flexibility for handling larger numeric values.Detailed summary
chainId
inTypedDataDomain
type to acceptbigint
inpackages/abitype/src/abi.ts
.chainId
inTypedDataDomain
Zod schema to allowbigint
inpackages/abitype/src/zod.ts
.