Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country content: Fix plugin... again #9394

Merged

Conversation

EricDunsworth
Copy link
Member

@EricDunsworth
Copy link
Member Author

EricDunsworth commented Jul 18, 2022

Heads up to any reviewers - this plugin caches country codes in local storage via the countryCode key. Might need to delete the key while testing.

@EricDunsworth
Copy link
Member Author

FWIW GitHub Actions' build failures don't seem to have anything to do with this PR's changes.

@EricDunsworth
Copy link
Member Author

EricDunsworth commented Jul 20, 2022

I think I've figured out what's up with GitHub Actions...

The Rake step runs HTMLProofer to check links and is currently producing a few dozen errors.

Looks like it first started on July 13th in #9321. Not as a result of anything that changed in the repo, but as a result of HTMLProofer having been updated to v4. An overview of major changes between 3.x and 4.x can be found in its UPGRADING file.

Copy link
Contributor

@GormFrank GormFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved upon successful testing.

@BrahimMahadi Please test locally :)

* Replace all references to freegeoip.app (which stopped working in late April) with country.is and api.country.is
* Rename country_code JSON key to country
* Overview of country.is:
  * Has existed since 2014-2015
  * Site claims not to collect request logs
  * Doesn't have any usage limits according to lineofflight/country#17
  * Discovered it in public-apis/public-apis#geocoding
* Successor to wet-boew#8928
@EricDunsworth EricDunsworth force-pushed the v4.0-country-content-country.is branch from 69665d1 to 02bf3da Compare July 20, 2022 18:11
@EricDunsworth
Copy link
Member Author

Just rebased :)! Should start passing in 10-20 mins.

@BrahimMahadi
Copy link
Contributor

What is the path that I need to enter to test this? I can't seem to get it to work. I tried these but I get a "unknown revision or path not in the working tree:
git reset --hard upstream/v4.0-country-content-country.is
git reset --hard upstream/v4.0-country-content-country

@EricDunsworth
Copy link
Member Author

@BrahimMahadi You'll probably need to to add an extra EricDunsworth remote that points to https://github.com/EricDunsworth/wet-boew.git (i.e. my fork of wet-boew/wet-boew), then fetch from it and switch to its v4.0-country-content-country.is branch. That branch doesn't exist in the upstream remote.

@GormFrank GormFrank requested a review from BrahimMahadi July 20, 2022 22:52
@BrahimMahadi
Copy link
Contributor

Tested and everything works fine

Copy link
Contributor

@GormFrank GormFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @EricDunsworth, at least we'll have a working solution even if we decide to eventually switch again.

@BrahimMahadi Thank you for testing!

@GormFrank GormFrank merged commit 1dc1a1d into wet-boew:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants