-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Country content: Fix plugin... again #9394
Country content: Fix plugin... again #9394
Conversation
Heads up to any reviewers - this plugin caches country codes in local storage via the |
FWIW GitHub Actions' build failures don't seem to have anything to do with this PR's changes. |
I think I've figured out what's up with GitHub Actions... The Rake step runs HTMLProofer to check links and is currently producing a few dozen errors. Looks like it first started on July 13th in #9321. Not as a result of anything that changed in the repo, but as a result of HTMLProofer having been updated to v4. An overview of major changes between 3.x and 4.x can be found in its UPGRADING file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved upon successful testing.
@BrahimMahadi Please test locally :)
* Replace all references to freegeoip.app (which stopped working in late April) with country.is and api.country.is * Rename country_code JSON key to country * Overview of country.is: * Has existed since 2014-2015 * Site claims not to collect request logs * Doesn't have any usage limits according to lineofflight/country#17 * Discovered it in public-apis/public-apis#geocoding * Successor to wet-boew#8928
69665d1
to
02bf3da
Compare
Just rebased :)! Should start passing in 10-20 mins. |
What is the path that I need to enter to test this? I can't seem to get it to work. I tried these but I get a "unknown revision or path not in the working tree: |
@BrahimMahadi You'll probably need to to add an extra |
Tested and everything works fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @EricDunsworth, at least we'll have a working solution even if we decide to eventually switch again.
@BrahimMahadi Thank you for testing!
country_code
JSON key tocountry