Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override twitter bootstrap's a:focus outline treatment #3671

Merged
merged 1 commit into from
Nov 20, 2013
Merged

override twitter bootstrap's a:focus outline treatment #3671

merged 1 commit into from
Nov 20, 2013

Conversation

masterbee
Copy link
Member

  • Tweaked and corrected the CSS outline override from Twitter bootstrap to ensure outline is visible
  • Retained the thin dotted as per recommendation from a11yproject to normalize across Webkit browsers as well [http://a11yproject.com/posts/never-remove-css-outlines/]

pjackson28 pushed a commit that referenced this pull request Nov 20, 2013
override twitter bootstrap's a:focus outline treatment
@pjackson28 pjackson28 merged commit 8cfe2d4 into wet-boew:v4.0 Nov 20, 2013
@pjackson28
Copy link
Member

Looks good. Will you be submitting a PR or an issue upstream as well?

@masterbee
Copy link
Member Author

@pjackson28 - Yep and thanks.

@pjackson28
Copy link
Member

@masterbee Unfortunately this fix doesn't work in Firefox. It seems that Firefox ignores setting the outline to "invert" (supposedly dropped support back in version 3 - https://bugzilla.mozilla.org/show_bug.cgi?id=359497). Possibly the only way to fix this is to prevent Bootstrap from setting the outline-color in the first place.

@masterbee
Copy link
Member Author

@pjackson28 - They want to still keep the Webkit treatment that is in there ( Webkit's glow which is default for the browser ) but will be dropping the colour as per my PR twbs/bootstrap#11551.

@pjackson28
Copy link
Member

@masterbee Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants