-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page details: Remove col-lg-9 class #2398
Page details: Remove col-lg-9 class #2398
Conversation
993123d
to
2d134cb
Compare
2d134cb
to
c04a49a
Compare
@Garneauma @duboisp This PR should be ready to review now :)! Btw please keep in mind that all outdated comments are still relevant... Turns out that force-pushing causes file comments to get marked as outdated... even though the same doesn't apply to unchanged line comments :S. It's also worth noting that I was unable to test this PR's changes first-hand (apart from the class removal lol). Although I followed #2377's structure super closely and aren't expecting any surprises. |
Pre-approved upon successful review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes:
- Rename page-details-v4.html to page-details-v3.1.html (en and fr)
- Thank you for adding instructions to migrate from 3.1 to 3.2, but let's merge 3.1 and 3.2 in the instructions and just have a tab for migrating from 3.0 to 3.2 as 3.1 has been live for such a short time.
49427fa
to
ecf044f
Compare
I think this is good to go now :)! Latest changes:
|
ecf044f
to
a9262b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure all references to version 4 and 5 are updated to 3.1 and 3.2.
d982b4a
to
2344251
Compare
There's no need for it. The col-md-9 class it was paired with already fulfils the same purpose (has the same grid width and scales up to larger views). Using wet-boew#2377 as a basis, this removes the col-lg-9 class and updates code samples/documentation/etc accordingly. Also adds the following updates: * Adjust the Bootstrap 3 static header and footer page's page details section (was using the col-lg-9 class and share this page...) * Revise the page details docs' implementation notes and migration instructions * Allow HTML to be rendered in history notes (via "isHTML": true, for non-breaking spaces and HTML tags) * Base include file names on component version numbers instead of iteration numbers (i.e. renamed 4 to 3.1 and 5 to 3.2) Co-authored-by: Garneauma <garneauma@gmail.com>
2344251
to
1f64482
Compare
Net-new updates:
|
There's no need for it. The
col-md-9
class it was paired with already fulfils the same purpose (has the same grid width and scales up to larger views).Using #2377 as a basis, this removes the
col-lg-9
class and updates code samples/documentation/etc accordingly.Also adds the following updates:
col-lg-9
class and share this page...)"isHTML": true
, for non-breaking spaces and HTML tags)