Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page details: Remove col-lg-9 class #2398

Merged

Conversation

EricDunsworth
Copy link
Member

@EricDunsworth EricDunsworth commented Jul 12, 2024

There's no need for it. The col-md-9 class it was paired with already fulfils the same purpose (has the same grid width and scales up to larger views).

Using #2377 as a basis, this removes the col-lg-9 class and updates code samples/documentation/etc accordingly.

Also adds the following updates:

  • Adjust the Bootstrap 3 static header and footer page's page details section (was using the col-lg-9 class and share this page...)
  • Revise the page details docs' implementation notes and migration instructions
  • Allow HTML to be rendered in history notes (via "isHTML": true, for non-breaking spaces and HTML tags)
  • Base include file names on component version numbers instead of iteration numbers (i.e. renamed 4 to 3.1 and 5 to 3.2)

@EricDunsworth EricDunsworth marked this pull request as ready for review July 16, 2024 17:47
@EricDunsworth
Copy link
Member Author

@Garneauma @duboisp This PR should be ready to review now :)!

Btw please keep in mind that all outdated comments are still relevant... Turns out that force-pushing causes file comments to get marked as outdated... even though the same doesn't apply to unchanged line comments :S.

It's also worth noting that I was unable to test this PR's changes first-hand (apart from the class removal lol). Although I followed #2377's structure super closely and aren't expecting any surprises.

@Garneauma
Copy link
Contributor

Pre-approved upon successful review.

Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes:

  • Rename page-details-v4.html to page-details-v3.1.html (en and fr)
  • Thank you for adding instructions to migrate from 3.1 to 3.2, but let's merge 3.1 and 3.2 in the instructions and just have a tab for migrating from 3.0 to 3.2 as 3.1 has been live for such a short time.

sites/page-details/demoted/page-details-v4-en.html Outdated Show resolved Hide resolved
sites/page-details/demoted/page-details-v4-fr.html Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
docs/static-header-footer/bootstrap-3.html Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
@EricDunsworth
Copy link
Member Author

EricDunsworth commented Jul 23, 2024

I think this is good to go now :)!

Latest changes:

  • Changed file version numbers from 4 to 3.1:
    • _includes/sites/page-details/page-details-4-*.html -> _includes/sites/page-details/page-details-3.1-*.html
    • sites/page-details/demoted/page-details-v4-*.html -> sites/page-details/demoted/page-details-v3.1-*.html
    • sites/page-details/samples/page-details-4-*.html -> sites/page-details/samples/page-details-3.1-*.html
  • Changed file version numbers from 5 to 3.2:
    • _includes/sites/page-details/page-details-5-*.html -> _includes/sites/page-details/page-details-3.2-*.html
    • sites/page-details/samples/page-details-5-*.html -> sites/page-details/samples/page-details-3.2-*.html
  • Updated renamed file references
  • Renamed 4.0 to 3.1 in a random include reference (via suggested commits)
  • Revised the implementation section's note about <footer>/<article> (via suggested commits):
    • Minor adjustment: Removed "the" from the English version of "However, for the version 2.0..." (kept "la" in French)
  • Implementation migration instructions:
    • Removed 3.1 to 3.2 section (via suggested commit)
    • Revised the 3.0 to 3.1 section to cover 3.0 to 3.2:
      • Renamed its implementation ID from implement_pd_3to4 to implement_pd_3to5
  • Updated modified dates
  • Revised commit/OP message
  • Added @Garneauma as a co-author

Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure all references to version 4 and 5 are updated to 3.1 and 3.2.

sites/page-details/index.json-ld Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
sites/page-details/demoted/page-details-v3.1-en.html Outdated Show resolved Hide resolved
sites/page-details/demoted/page-details-v3.1-fr.html Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
There's no need for it. The col-md-9 class it was paired with already fulfils the same purpose (has the same grid width and scales up to larger views).

Using wet-boew#2377 as a basis, this removes the col-lg-9 class and updates code samples/documentation/etc accordingly.

Also adds the following updates:
* Adjust the Bootstrap 3 static header and footer page's page details section (was using the col-lg-9 class and share this page...)
* Revise the page details docs' implementation notes and migration instructions
* Allow HTML to be rendered in history notes (via "isHTML": true, for non-breaking spaces and HTML tags)
* Base include file names on component version numbers instead of iteration numbers (i.e. renamed 4 to 3.1 and 5 to 3.2)

Co-authored-by: Garneauma <garneauma@gmail.com>
@EricDunsworth
Copy link
Member Author

EricDunsworth commented Jul 24, 2024

Net-new updates:

  • sites/page-details/page-details-default-*.html and sites/page-details/page-details-pft-*.html:
    • Updated AJAX references from 4 (3.1) to 3.2
    • Changed modified dates from 2024-06-03 to today
  • sites/page-details/demoted/page-details-v3.1-*.html (previously v4.0):
    • Renamed all mentions of 4.0 to 3.1 in page titles/content areas
  • Fixed outdated file name references in JSON files
  • Updated modified dates

@Garneauma Garneauma merged commit 7e7b444 into wet-boew:master Jul 24, 2024
1 check passed
@Garneauma Garneauma added this to the v15.4.0 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants