Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default app compose build target #268

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix default app compose build target #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b48037e
fix default app compose build target
joshuadavidthomas Aug 2, 2024
7211f3d
update changelog
joshuadavidthomas Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
### Fixed

- Fixed reference to correct `lock` command in `just docs upgrade` just command.
- Changed the `default-app` build target from `app` to `dev`. This fixes an error running the stack in development where the worker container does not have the development dependencies installed.

## [2024.40]

Expand Down
4 changes: 1 addition & 3 deletions src/django_twc_project/compose.yml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ x-default-app: &default-app
build:
context: .
dockerfile: Dockerfile
target: app
target: dev
env_file: .env
init: true
user: "${UID:-1000}:${GID:-1000}"
Expand All @@ -17,8 +17,6 @@ x-default-app: &default-app
services:
app:
<<: *default-app
build:
target: dev
command: python manage.py runserver 0.0.0.0:8000 --skip-checks
{%- if include_vite %}
depends_on:
Expand Down