Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚜 Migrate Black and pyupgrade to Ruff #58

Merged
merged 3 commits into from
Oct 24, 2023
Merged

🚜 Migrate Black and pyupgrade to Ruff #58

merged 3 commits into from
Oct 24, 2023

Conversation

jefftriplett
Copy link
Contributor

Inspired by: https://astral.sh/blog/the-ruff-formatter

There might be some version weirdness to work through for the full black support to take. I noticed this gave an error when enabled:

# Like Black, respect magic trailing commas.
magic-trailing-comma = "respect"

See: https://docs.astral.sh/ruff/configuration/#using-pyprojecttoml

@jefftriplett jefftriplett marked this pull request as ready for review October 24, 2023 19:12
@jefftriplett jefftriplett changed the title 🚜 Migrate Black to Ruff 🚜 Migrate Black and pyupgrade to Ruff Oct 24, 2023
joshuadavidthomas
joshuadavidthomas approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@joshuadavidthomas joshuadavidthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jefftriplett jefftriplett merged commit 38d3d1a into main Oct 24, 2023
23 checks passed
@jefftriplett jefftriplett deleted the upgrade-ruff branch October 24, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuadavidthomas joshuadavidthomas joshuadavidthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jefftriplett @joshuadavidthomas