-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong Imports in Generated .d.ts
on Windows
#21
Comments
It works fine under OS X (without the duplicated imports). Seems like a problem related to path. |
d.ts
.d.ts
on Windows
Hi there, thanks for reporting this issue. Looking at the image, the import paths look wrong, so I'm certain that the issue is related to how relative paths are computed by the plugin. I'll try to spin up a Windows VM and test it |
Is there any code determining whether a symbol is bundled or imported? As the picture shows, the |
Yes there is, but grouped by emitted chunk, and since the import paths are broken, the logic for determining whether or not symbols are defined is broken on Windows |
Any help I can try? Not familiar with code but the plugin is awesome. It's better than the official one. |
I'm on a Windows 10 box and I'd like to offer my help, too, should you need some. I just switched to rollup-plugin-ts to build my own plugin. For now, I'm using a separate build step to generate the declaration file and I'd rather have your plugin do all the dirty job 😁 in one step. I've tried taking a look at your source code but it's dense and hard to follow when not used to. Just give some directions as to where to look in first. edit: FWIW, using a bunch of |
I'm investigating the issue, and the issue is related to a couple of things:
I'm working on fixing these things and I'm testing both on MacOS and Windows. I'll keep you posted. |
The issue has been fixed and released in v1.1.55. Thanks for reporting it! |
As the picture shown, the generated file
index.esm.d.ts
contains OS-specific path imports:More importantly,
Suggestion
interface is redefined...The text was updated successfully, but these errors were encountered: