fix: fix test case

wesql · Dec 16, 2024 · a2dee82 · a2dee82
1 parent b020b41
commit a2dee82
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 30 deletions.
diff --git a/go/vt/vtgate/engine/fake_vcursor_test.go b/go/vt/vtgate/engine/fake_vcursor_test.go
@@ -105,22 +105,12 @@ func (t *noopVCursor) AnyAdvisoryLockTaken() bool {
 	panic("implement me")
 }
 
-func (t *noopVCursor) GetExecutorVSchema() *vindexes.VSchema {
-	// TODO implement me
-	panic("implement me")
-}
-
 func (t *noopVCursor) VSchemaAddKeyspaceIfNotExists(name string, KeyspaceSchema *vindexes.KeyspaceSchema) {
-	panic("implement me")
+
 }
 
 func (t *noopVCursor) VSchemaDeleteKeyspace(name string) {
-	panic("implement me")
-}
 
-func (t *noopVCursor) GetVSchema() *vindexes.VSchema {
-	// TODO implement me
-	panic("implement me")
 }
 
 func (t *noopVCursor) AddAdvisoryLock(_ string) {
@@ -840,20 +830,10 @@ func (f *loggingVCursor) SetPlannerVersion(querypb.ExecuteOptions_PlannerVersion
 	panic("implement me")
 }
 
-func (f *loggingVCursor) GetExecutorVSchema() *vindexes.VSchema {
-	panic("implement me")
-}
-
 func (f *loggingVCursor) VSchemaAddKeyspaceIfNotExists(name string, KeyspaceSchema *vindexes.KeyspaceSchema) {
-	panic("implement me")
 }
 
 func (f *loggingVCursor) VSchemaDeleteKeyspace(name string) {
-	panic("implement me")
-}
-
-func (f *loggingVCursor) GetVSchema() {
-	panic("implement me")
 }
 
 func (f *loggingVCursor) FindRoutedTable(tbl sqlparser.TableName) (*vindexes.Table, error) {

diff --git a/go/vt/vtgate/engine/primitive.go b/go/vt/vtgate/engine/primitive.go
@@ -129,13 +129,9 @@ type (
 
 		FindHealthyPrimaryTablet() (*discovery.TabletHealth, error)
 
-		//GetExecutorVSchema() *vindexes.VSchema
-
 		VSchemaAddKeyspaceIfNotExists(name string, KeyspaceSchema *vindexes.KeyspaceSchema)
 
 		VSchemaDeleteKeyspace(name string)
-
-		//GetVSchema() *vindexes.VSchema
 	}
 
 	// SessionActions gives primitives ability to interact with the session state

diff --git a/go/vt/vtgate/vcursor_impl.go b/go/vt/vtgate/vcursor_impl.go
@@ -1217,11 +1217,6 @@ func (vc *vcursorImpl) ShowExec(ctx context.Context, command sqlparser.ShowComma
 		return nil, vterrors.Errorf(vtrpcpb.Code_INTERNAL, "bug: unexpected show command: %v", command)
 	}
 }
-
-func (vc *vcursorImpl) GetExecutorVSchema() *vindexes.VSchema {
-	return vc.executor.VSchema()
-}
-
 func (vc *vcursorImpl) VSchemaAddKeyspaceIfNotExists(name string, KeyspaceSchema *vindexes.KeyspaceSchema) {
 	vc.executor.VSchemaAddKeyspaceIfNotExists(name, KeyspaceSchema)
 }