Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/162830 choose scope of access token #9751

Open
wants to merge 22 commits into
base: feat/enhanced-access-token
Choose a base branch
from

Conversation

NaokiHigashi28
Copy link
Contributor

@NaokiHigashi28 NaokiHigashi28 commented Mar 17, 2025

2025-03-18.135723.mp4

Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: 2ae4e6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NaokiHigashi28 NaokiHigashi28 changed the base branch from feat/enhanced-access-token to feat/162829-162857-scope March 18, 2025 05:03
Base automatically changed from feat/162829-162857-scope to feat/enhanced-access-token March 21, 2025 10:10
margin-left: $i * 20px;
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいんだけど、
後々、identation-level-3 とかでプロジェクト内検索しても引っ掛からないのがデバッグする人がハマりそうなので、

.access-token-sope-list :global {
  .identation {
    &.identation-level-3 {  <--- ここは for .. from .. through でイテレート
      ...
    }
  }
}

として、styles['indentation']identation-level-3 が className に割り当てられるような仕組みにしてください

:global とか :local の入れ子がめんどいので、access-token-sope-list :global は用意した方が楽だと思う

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants