Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AuthorInfo display setting to PageSideContents #9689

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

satof3
Copy link
Contributor

@satof3 satof3 commented Feb 27, 2025

Task

https://redmine.weseek.co.jp/issues/160023

Summary

  • PageSideContentsにauthor infoを表示できる設定を追加
    • default ではオフになっている
    • md 以上の時に表示(sm以下では表示設定にしていても表示されない )
    • AuthorInfo で使われていなかった suvnav 部分を pageSide ととして利用
  • admin/customize/のfunctionに設定項目を追加
  • 共有リンクページにも反映

Screenshot

image image

@satof3 satof3 requested a review from yuki-takei February 27, 2025 08:40
@satof3 satof3 self-assigned this Feb 27, 2025
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: eb543f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

share/[[...path]].page.tsx でも PageSideContets を使うので同様の措置が必要だと思う

@yuki-takei yuki-takei changed the title imprv: Add AuthorInfo display setting to PageSideContents feat: Add AuthorInfo display setting to PageSideContents Mar 2, 2025
mergify bot added a commit that referenced this pull request Mar 2, 2025
Copy link
Contributor

mergify bot commented Mar 2, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify bot added a commit that referenced this pull request Mar 3, 2025
Copy link
Contributor

mergify bot commented Mar 3, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@yuki-takei
Copy link
Member

@mergify queue

Copy link
Contributor

mergify bot commented Mar 4, 2025

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@yuki-takei
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Mar 4, 2025

refresh

✅ Pull request refreshed

@yuki-takei
Copy link
Member

@Mergifyio queue

Copy link
Contributor

mergify bot commented Mar 4, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5664ee3

mergify bot added a commit that referenced this pull request Mar 4, 2025
@mergify mergify bot merged commit 5664ee3 into master Mar 4, 2025
22 of 23 checks passed
@mergify mergify bot deleted the imprv/162023-display-created-updated-option branch March 4, 2025 05:36
Copy link
Contributor

mergify bot commented Mar 4, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #9689 has been dequeued due to failing checks or checks timeout

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants