Skip to content

Merge pull request #372 from werf/refactor/move-some-deploy-code-from… #240

Merge pull request #372 from werf/refactor/move-some-deploy-code-from…

Merge pull request #372 from werf/refactor/move-some-deploy-code-from… #240

Triggered via push January 28, 2025 15:02
Status Failure
Total duration 4m 27s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
golangci-lint: pkg/engine/doc.go#L1
: # github.com/werf/3p-helm/pkg/engine [github.com/werf/3p-helm/pkg/engine.test]
golangci-lint: pkg/engine/engine_test.go#L191
not enough arguments in call to new(Engine).render
golangci-lint: pkg/engine/engine_test.go#L435
not enough arguments in call to e.render
golangci-lint: pkg/engine/engine_test.go#L454
not enough arguments in call to new(Engine).render
golangci-lint: pkg/engine/engine_test.go#L517
not enough arguments in call to new(Engine).render
golangci-lint: pkg/engine/engine_test.go#L535
not enough arguments in call to new(Engine).render
golangci-lint: pkg/engine/engine_test.go#L546
not enough arguments in call to e.render
golangci-lint: pkg/action/upgrade.go#L349
`occured` is a misspelling of `occurred` (misspell)
golangci-lint: pkg/action/action.go#L62
var `errPending` is unused (unused)
golangci-lint: pkg/werf/secrets/secrets_runtime_data.go#L6
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
golangci-lint: pkg/errs/errors.go#L45
errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive)
golangci-lint: pkg/werf/secrets/secrets_runtime_data.go#L22
exported: type name will be used as secrets.SecretsRuntimeData by other packages, and that stutters; consider calling this RuntimeData (revive)
golangci-lint: pkg/werf/secrets/secrets_runtime_data.go#L75
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
golangci-lint: pkg/werf/secrets/secrets_runtime_data.go#L83
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
golangci-lint: pkg/werf/secrets/secrets_runtime_data.go#L94
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
golangci-lint: pkg/chart/chart_extender.go#L8
exported: type name will be used as chart.ChartExtender by other packages, and that stutters; consider calling this Extender (revive)
golangci-lint: pkg/werf/chartextender/chart_extender_stub.go#L13
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
golangci-lint: pkg/werf/chartextender/chart_extender_stub.go#L70
unused-parameter: parameter 'annotations' seems to be unused, consider removing or renaming it as _ (revive)
golangci-lint: pkg/werf/chartextender/chart_extender_stub.go#L74
unused-parameter: parameter 'labels' seems to be unused, consider removing or renaming it as _ (revive)
golangci-lint: pkg/chartutil/dependencies.go#L542
superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)