-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 272 implement #357
base: master
Are you sure you want to change the base?
Issue 272 implement #357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are couple of main things we need to address before I can even start reviewing it:
- This should be off by default, this can break users' stuff. Since behaviour change like this can be very hard to debug
- We need a CLI flag to enable this feature
- We need to find some other way to evaluate variables,
re
is not good enough for that
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 83 96 +13
Branches 18 21 +3
=========================================
+ Hits 83 96 +13 ☔ View full report in Codecov by Sentry. |
Done. |
#272