-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an additional Caddyfile config template to the existing template #50
Conversation
I could also add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Two questions:
- Is it possible to test this easily?
- Can you please rebase you PR on
master
?
Update master
modifying the docker-gen template file
I'll think of a way to test, I'll update the |
@sobolevn I rebased with master and added tests to the CI, any feedback is welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, please you review my sh
style fixes.
If that's ok, I would merge it right away! 👍
Looks like I broke something 😢 |
snippet definitions can be easily inserted for use in template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Great work!
This could be a potential fix for #2 , not sure if you all would prefer to add to the existing template, or replace it altogether. There could be separate env var for each option. What do you think of these changes? (explanation in README changes)