-
Notifications
You must be signed in to change notification settings - Fork 9
Breakdown extras #372
Breakdown extras #372
Conversation
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
===========================================
- Coverage 84.78% 28.25% -56.53%
===========================================
Files 42 42
Lines 2576 2651 +75
===========================================
- Hits 2184 749 -1435
- Misses 392 1902 +1510
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I see what you mean about the errors, but i think what you have done looks good 👍
@aCampello this is super, awesome contributions, much kudos 👍 👍 🚀 |
hang on a minute, what happened here? This looked good a minute ago |
Some usual codecov weirdness with the GitHub action that we get from time to time. If we go to the actual link, it tells that it doesn't change much https://app.codecov.io/gh/wellcometrust/WellcomeML/pulls?page=1&state=open&order=-pullid |
No excuse not to use WellcomeML @ivyleavedtoadflax, let's use it more over at Mantis as well :) |
Description
Fixes #366.
In particular, this reduces the "vanilla" environment to 109MB and the
all
environment to about 2.1GB.It makes a bit more complicated to add new functionality. When you
import
something you need to check which extra it is part of, and throw the correct error message. Maybe in the future we can automate that, but for now it is fine.The idea is that this will encourage people to use io functionalities, but also potentially EPMC api wrapper, dataset downloaders etc.
How to review:
Check
setup.py
andREADME.md
and then really just skim through the rest.Checklist