WELD-2787 Remove legacy integration points for Jetty #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2024
manovotn
commented
Apr 25, 2024
| } | ||
|
|
||
| @Override | ||
| public void initialize(ContainerContext context) { | ||
| try { | ||
| ServletContext servletContext = context.getServletContext(); | ||
| String mode = (String) servletContext.getAttribute(JETTY_CDI_ATTRIBUTE); | ||
| if (mode == null) { | ||
| mode = DECORATING_LISTENER_MODE; | ||
| } | ||
| switch (mode) { | ||
| case CDI_SPI_DECORATOR_MODE: |
There was a problem hiding this comment.
According to arquillian/arquillian-container-jetty#197 (comment), this is Jetty's internal class. I suppose the only purpose it serves here is telling apart an undefined state (i.e. throwing an exception) versus this state which, for us, is just a no-op.
I'll add a code comment for my future self to remember that.
There was a problem hiding this comment.
I've added a code comment clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in linked Arq. jetty adapter, I think the integration can be simplified to the following.
Note that removing these legacy parts in 5.x doesn't really matter as they play no role in current Jetty versions anyway and you cannot use this version of Weld with older versions of Jetty.