Extend MeasureTool by angle tool #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the MeasureTool by a new functionality to measure an azimuth by drawing a 2-point line.
JakobMiksch
reviewed
Jul 19, 2023
src/util/Angle.js
Outdated
Comment on lines
12
to
14
| * @param {Array<Number>} start The start coordinates of the line with the | ||
| * x-coordinate being at index `0` and y-coordinate being at index `1`. | ||
| * @param {Array<Number>} end The end coordinates of the line with the |
There was a problem hiding this comment.
maybe here as type an OpenLayers coordinate can be used: https://openlayers.org/en/latest/apidoc/module-ol_coordinate.html#~Coordinate
src/util/Angle.js
Outdated
Comment on lines
35
to
37
| * @param {Array<Number>} start The start coordinates of the line with the | ||
| * x-coordinate being at index `0` and y-coordinate being at index `1`. | ||
| * @param {Array<Number>} end The end coordinates of the line with the |
There was a problem hiding this comment.
maybe here as type an OpenLayers coordinate can be used: https://openlayers.org/en/latest/apidoc/module-ol_coordinate.html#~Coordinate
| }, | ||
| data () { | ||
| return { | ||
| area: ' -- ', | ||
| distance: ' -- ' | ||
| distance: ' -- ', |
There was a problem hiding this comment.
the string -- appears quite often and could be extracted to an constant. But that's more a matter of taste ...
JakobMiksch
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
MeasureToolby a new functionality to measure/calculate an azimuth by drawing a 2-point line:The function is hidden by default, so the
MeasureToollooks as before in case anything is changed. To show / activate the functionality a new config propertyshowAngleToolis introduced for theMeasureToolmodule. So by setting this property totruein theapp-conf.jsonyou'll see the new angle tool.