Add app-wide loading mask component #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an app-wide loading mask component, which covers the application and shows a loading spinner.
fschmenger
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
This works out as expected. Another useful feature.
You could possibly enhance the unit test to $emit the event and check the show attribute.
Approved anyway, if you want to merge.
Since we have a couple of new features by now, could you bump up the minor version?
|
Thanks for your review @fschmenger. I added some tests regarding the 'app-loading-mask-toggle' event (see 10d0875). I am going to merge now.
I also had that in mind and come up with that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an app-wide loading mask component, which covers the application and shows a loading spinner:
Quite useful when performing essential AJAX requests, where the user should not interact with the application.
To toggle the loading mask you could use
WguEventBus.$emit('app-loading-mask-toggle');or in order to explicitly set a visibility for the mask one could useWguEventBus.$emit('app-loading-mask-toggle', newViz);.