Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade non-dev dependencies #295

Closed
wants to merge 1 commit into from

Conversation

chrismayer
Copy link
Collaborator

This upgrades the "non-dev" dependencies to minor and patch releases, which can applied without significant code changes.

OpenLayers upgrade should be done separately since there has been some work done in #261

This upgrades the "non-dev" dependencies to minor and patch releases,
which can applied without significant code changes.
@chrismayer chrismayer marked this pull request as draft July 21, 2022 14:50
@fschmenger
Copy link
Collaborator

fschmenger commented Nov 2, 2022

Hi @chrismayer,
I finally found some time to give this a brief test. At the time of writing this some package (minor) versions no longer correspond to the newest ones available, so I decided to give it a shot with this configuration:

"dependencies": {
    "axios": "0.27.2",
    "canvas-record": "3.1.0",
    "ol": "6.4.3",
    "proj4": "2.8.0",
    "vue": "2.7.13",
    "vue-i18n": "8.28.2",
    "vuetify": "2.6.12"
  },
 "devDependencies": {
    ...
    "vue-template-compiler": "2.7.13",
}

Here are my findings so far:

  • A warning appears: [Vuetify] [UPGRADE] 'v-content' is deprecated, use 'v-main' instead.
  • In my custom application it breaks some internal dependencies of apache-echarts ("vue-echarts": "^6.0.0"), so these are no longer working.
  • My hover-cards changed in layout and are now somehow truncated at the bottom (no special css is involved there).
  • As you already discovered, the css rule regarding the app logo has to be changed - apparently there are some internal changes to classes assigned by vuetify.

This might be just the tip of the iceberg. So after all my conclusion is, that we should do this in the same run as #297 (or the upcoming cli-v4-PR) when moving to Wegue v2.

Greets, Felix.

@sronveaux
Copy link
Collaborator

Hi @chrismayer ,

I just wanted to complement a little bit the comment of @fschmenger.

I personally think you should indeed wait to be using at least the VueCLI V4 for the following two reasons:

  • If you read the upgrade guide to Vue 2.7, it is written that you first have to upgrade your local @vue/cli-xxx dependencies to the latest version in your major version range... and only v4 and v5 are listed there.
    It doesn't mean that it can't work with Vue-CLI V2 which is used now in Wegue, just that it is not supported...
  • Concerning Vuetify and the warnings, they have developed a plugin for ESLint which returns all those deprecation warnings. However, this plugin needs ESLint6 at minimum and wegue currently uses ESLint5. The upgrade of VueCLI also upgrades ESLint. So we'll be able to add the Vuetify plugin in Wegue to help find those potential problems.
    I once read a little bit what was new and it unfortunately seems this is the only mentioned big change to do (replacing v-content by v-main). This means all the display errors that @fschmenger discovered will certainly have to be tackled one by one unfortunately...

Cheers,
Sebastien

@spwoodcock
Copy link
Contributor

Would it be helpful for me to merge this into #320, to consolidate the changes and resolve conflicts?

@chrismayer
Copy link
Collaborator Author

Superseded by #335 - closing.

@chrismayer chrismayer closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants