-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks for DraggableWin directive #292
Conversation
@ntma Hi Nuno, thanks for kickstarting this! I'm currently a little limited in time but can give it a test run by next week hopefully. Keep in mind that Task 3) will be a breaking change due to the changes in positioning offsets. Probably this should be in a separate PR, so it can be incorporated with the next Wegue major version. |
Hi @fschmenger , no problem!
Indeed, I got to agree with that. I will take your suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not really understand the change here. Could you explain what the behavior before and after this PR is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine from my side. I tested it and it does what it should.
@fschmenger maybe could have a look and merge if you approve. |
Thanks @ntma for this. LGTM 👍 As @JakobMiksch suggested, let's see what @fschmenger says and if he approves feel free to merge afterwards. |
OK, this looks good to merge. I can finally see the I suggest we leave #252 open, until the other topics can be addressed for v2. |
Fixes:
Constain floating windows to the main container;(future PR)#252