Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for DraggableWin directive #292

Merged
merged 2 commits into from
May 25, 2022

Conversation

ntma
Copy link
Contributor

@ntma ntma commented Apr 25, 2022

Fixes:

  • Support for Firefox (e.path is Google Chrome specific);
  • Reset dragger offset for each mousedown event (prevents magical jumps);
  • Constain floating windows to the main container; (future PR)

#252

@ntma ntma changed the title Tweets for DraggableWin directive Tweaks for DraggableWin directive Apr 25, 2022
@fschmenger
Copy link
Collaborator

@ntma Hi Nuno, thanks for kickstarting this! I'm currently a little limited in time but can give it a test run by next week hopefully.

Keep in mind that Task 3) will be a breaking change due to the changes in positioning offsets. Probably this should be in a separate PR, so it can be incorporated with the next Wegue major version.

@ntma
Copy link
Contributor Author

ntma commented Apr 25, 2022

Hi @fschmenger , no problem!

Keep in mind that Task 3) will be a breaking change due to the changes in positioning offsets. Probably this should be in a separate PR, so it can be incorporated with the next Wegue major version.

Indeed, I got to agree with that. I will take your suggestion!

Copy link
Collaborator

@JakobMiksch JakobMiksch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really understand the change here. Could you explain what the behavior before and after this PR is?

src/directives/DraggableWin.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@JakobMiksch JakobMiksch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from my side. I tested it and it does what it should.

@JakobMiksch
Copy link
Collaborator

@fschmenger maybe could have a look and merge if you approve.

@chrismayer
Copy link
Collaborator

Thanks @ntma for this. LGTM 👍 As @JakobMiksch suggested, let's see what @fschmenger says and if he approves feel free to merge afterwards.

@fschmenger
Copy link
Collaborator

OK, this looks good to merge. I can finally see the draggable option working in Firefox and it no longer get's confused when dragging multiple cards.

I suggest we leave #252 open, until the other topics can be addressed for v2.

@fschmenger fschmenger merged commit fea4386 into wegue-oss:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants