-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview map #266
Overview map #266
Conversation
I provide this as a preview for investigation. Maybe you should wait with merging until #262 is included in the main branch, so I can adjust the colorization part. Also I will add some basic unit tests and documentation upon finalization. Some topics to discuss:
|
Thanks for kickstarting this @fschmenger. Regarding layout: I do not like having it with an "OL button". Since it is a comparable tool to the Maybe we place different buttons in the upper-left corer of the map, which is surely limited if more components would come into play and not sure how to arrange the open components, e.g. having Anotehr option would be to introduce a circular menu, shwoing the underlying map-related tools on clicking the main button. But the problem remains, how to place the concrete windows / components? Any ideas? Third option would be to place it in the lower-right corner of the map as you did, but with a vuetify button. This would mean that we have to find another default spot for the floating measure window. Which is surely no problem (hopefully 😉 🤞 ) Thinking about this it might make sense to rework the zoom buttons as vuetify buttons as well? We had that in other projects with other frameworks, to have a common look and feel: Please ignore the "wrong" icons (did not have any proper in my sketching tool) |
@chrismayer Thanks for the review and the provided feedback. I will work towards a vuetify based button and a v-sheet then - probably something along the lines of you first sketch and then we can refine it later. One problem that I see is, that in contrast to the Anyway I can start reworking this when time, and we can discuss the placement issues in the process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jakob, thanks for the review. So far I wasn't aware, that a map configuration without at least 1 declared base layer is valid. Anyway I see no need to disable the overview map in this case, as this feature does not depend on base layers directly. If you have any ideas on improving the layout and positioning, let me know. |
Hi @fschmenger . I was not aware that it is compulsory to have at least one baselayer. I could image applications without baselayers. But I admit, that these are rather exceptions. Using the OSM layer as default is fine for me. |
Ok, z-index and OSM fallback are in there. |
I found a fix for the selection box issue. So apart from documentation, unit tests and the upcoming colorization part that should be all the basics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it again and it seems to be fine to merge.
@JakobMiksch Thanks for testing and approving this! I will merge / rebase with the newly integrated theming PR and make some minor adjustments for the overview map to be theming consistent. Also I will provide unit tests and some basic documentation. This probably will be after the christmas break. |
…ithout any colorization of customization options.
…oes not perform any vue component rendering.
…lor. Use a vuetify card like design for the control.
…y type for 'label'
… or module windows.
…ich is displayed when no baseLayers are configured.
…overview maps to be initially collapsed. Remove no longer supported 'collapsible' attribute.
…to avoid trouble with unit tests.
…t, when no appConfig object is defined.
…s on unit tests (e.g. dangling layers between tests). Fire 'ol-map-unmounted' before destroying references, to give map based controls the chance to tidy up.
…uration example from the current app-conf.json.
464a202
to
a336ffc
Compare
I rebased this PR on the current master branch and adjusted it to be theme compliant. Unit tests and documentation have been provided. As a far as I am concerned this should be ready to merge now. |
Co-authored-by: Jakob Miksch <info@jakobmiksch.eu>
@JakobMiksch Thanks a lot for reviewing this, Jakob! |
Thanks for this @fschmenger. |
This branch adds OpenLayers overview maps as a configurable component (closes #204).
The control will be added to the map, when a top level
overviewMap
configuration option is declared.I added an example to various app templates, e.g.