-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar configuration #251
Sidebar configuration #251
Conversation
…lected module visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine and it works well.
Two minor note inline.
Otherwise ready to merge from my side.
thanks @fschmenger
Co-authored-by: Jakob Miksch <info@jakobmiksch.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @fschmenger. Will merge once the conflicts are resolved.
OK, only a minor conflict in the documentation, was easy enough to resolve. |
This adds a
sidebar
configuration object to the application context, to customize some basic sidebar behavior - closes #217.A new sidebar scrolling feature has been implemented, to automatically scroll to the active module, typically after a new module becomes visible.
I also decided to rework the style of the sidebar toggle button to give it a bit nicer appearance.
The documentation has been updated accordingly.