Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar configuration #251

Merged
merged 13 commits into from
Nov 5, 2021
Merged

Conversation

fschmenger
Copy link
Collaborator

This adds a sidebar configuration object to the application context, to customize some basic sidebar behavior - closes #217.

"sidebar": {
  "visible": true,
  "width": 400,
  "color": "white",
  "autoScroll": true,
  "scrollDuration": 500
}

A new sidebar scrolling feature has been implemented, to automatically scroll to the active module, typically after a new module becomes visible.
I also decided to rework the style of the sidebar toggle button to give it a bit nicer appearance.

The documentation has been updated accordingly.

Copy link
Collaborator

@JakobMiksch JakobMiksch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and it works well.
Two minor note inline.
Otherwise ready to merge from my side.
thanks @fschmenger

app-starter/WguAppTemplate.vue Outdated Show resolved Hide resolved
docs/wegue-configuration.md Outdated Show resolved Hide resolved
Co-authored-by: Jakob Miksch <info@jakobmiksch.eu>
Copy link
Collaborator

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fschmenger. Will merge once the conflicts are resolved.

@fschmenger
Copy link
Collaborator Author

OK, only a minor conflict in the documentation, was easy enough to resolve.

@chrismayer chrismayer merged commit 96be98d into wegue-oss:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration for initial sidebar visibility
3 participants