Map layer options #249
Merged
Map layer options #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configured, zIndex will default to -1 for base layers and 0 for all other layers.
…ayer types. Options initialization order has been changed in layer factory, to use the same structure for all layer types.
…is not supported across all layer types.
JakobMiksch
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
I tried the Z-Index. It works well.
The refactoring in the LayerFactory is very useful.
Ready to merge from my side.
Thanks @fschmenger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch reworks some of the map layer configuration options. There should be no backward compability issues:
zIndexis introduced - resolves Add support for zIndex when customizing layers. #230. Regarding default values, I decided to assign -1 to base layers and 0 to other layers, which seems to be the least invasive approach.extentoption is now consistently supported across all layer types.