Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend integration #1

Merged
merged 13 commits into from
Mar 26, 2024
Merged

Frontend integration #1

merged 13 commits into from
Mar 26, 2024

Conversation

Dennisprins93
Copy link
Contributor

No description provided.

@erikfrerejean erikfrerejean mentioned this pull request Feb 15, 2024
Closed
Mirjana Durakovic and others added 2 commits February 16, 2024 12:14
erikfrerejean
erikfrerejean reviewed Feb 29, 2024
View reviewed changes
src/Controllers/AdminToolbarActionController.php Outdated Show resolved Hide resolved
src/Controllers/AdminToolbarActionController.php Outdated Show resolved Hide resolved
src/Controllers/AdminToolbarActionController.php Outdated Show resolved Hide resolved
src/Controllers/AdminToolbarActionController.php Outdated Show resolved Hide resolved
src/Menus/ElementalGrid/ElementalGridMenu.php Outdated Show resolved Hide resolved
src/Menus/ElementalGrid/ElementalGridMenu.php Show resolved Hide resolved
@erikfrerejean
Copy link
Member

@Dennisprins93 there are a lot of getOrder() methods with magic numbers which I assume are used to sort the elements in the toolbar. Can we find a way to get rid of those? They give the idea that you can change the ordering of the elements but I don't think there is a way to influence these values.

erikfrerejean
erikfrerejean requested changes Mar 26, 2024
View reviewed changes
client/src/js/app.js Show resolved Hide resolved
src/Controllers/AdminToolbarActionController.php Outdated Show resolved Hide resolved
src/Menus/Page/MenuItems/ArchiveMenuItem.php Outdated Show resolved Hide resolved
src/Menus/Page/MenuItems/UnpublishAndArchiveMenuItem.php Outdated Show resolved Hide resolved
src/Menus/Page/MenuItems/UnpublishMenuItem.php Outdated Show resolved Hide resolved
src/Menus/Page/MenuItems/EditMenuItem.php Outdated Show resolved Hide resolved
src/Menus/Page/MenuItems/UnpublishAndArchiveMenuItem.php Outdated Show resolved Hide resolved
src/Menus/Page/MenuItems/UnpublishMenuItem.php Outdated Show resolved Hide resolved
src/Menus/Page/PageMenu.php Show resolved Hide resolved
client/dist/app.js Outdated Show resolved Hide resolved
@Dennisprins93 Dennisprins93 merged commit 2f1c559 into main Mar 26, 2024
@Dennisprins93 Dennisprins93 deleted the ss-5-wip branch March 26, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikfrerejean erikfrerejean erikfrerejean approved these changes

Assignees

@Dennisprins93 Dennisprins93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dennisprins93 @erikfrerejean