Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update workflows for node ^12 #1993

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Conversation

kis87988
Copy link
Contributor

@kis87988 kis87988 commented Jun 9, 2020

I'm submitting a...

[ ] Bug Fix
[ ] Feature
[x] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

I see the commit id:608bbd2f2b6594a7725e1cec21ba6c120cacffa0 with require node v12^
seem reasonable to remove v10, and v11 because that is below the require for the node.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@kis87988 kis87988 requested a review from huan June 9, 2020 18:29
@huan
Copy link
Member

huan commented Jun 9, 2020

Cloud yo please explain the reason why do you remove the Node.js v10 & v11 from the CI?

@kis87988
Copy link
Contributor Author

kis87988 commented Jun 9, 2020

@huan,

I see the commit 608bbd2 with require node v12^
seem reasonable to remove v10, and v11 because that is below the requirement for the node.

But we may still check the old version for the node since some puppet still use v10

@huan huan merged commit 7db0ca9 into wechaty:master Jun 9, 2020
@huan
Copy link
Member

huan commented Jun 9, 2020

Thank you for the explanation, I think we should drop the Node v10 & v11 because the current Node.js LTS version is 12.

Especially, the Array.prototype.flat() is not supported by the versions below 12, and I do love it so I begin using it a lot.

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants