Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick test #3

Closed
wants to merge 4 commits into from
Closed

quick test #3

wants to merge 4 commits into from

Conversation

wj-Mcat
Copy link
Collaborator

@wj-Mcat wj-Mcat commented Feb 29, 2020

writer : 吴京京
content : some typing python functions

@claassistantio
Copy link

claassistantio commented Feb 29, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wj-Mcat
❌ wjmcat


wjmcat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@huan
Copy link
Member

huan commented Feb 29, 2020

Thanks for your code, It looks great!

Cloud you please sign the CLA by following the reply from CLA bot before we continue to process it?

@wj-Mcat
Copy link
Collaborator Author

wj-Mcat commented Feb 29, 2020

I have signed CLA

@huan
Copy link
Member

huan commented Feb 29, 2020

@wj-Mcat It seems that your email address does not match in your commits.

wjmcat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Please fix it so that the CLA bot will turn green, thanks!

@wj-Mcat
Copy link
Collaborator Author

wj-Mcat commented Feb 29, 2020

I have changed my local email address.

flake8 3.7.9 has requirement pycodestyle<2.6.0,>=2.5.0, but you have pycodestyle 2.3.1.

The error from Travis CI is that the version of pycodestyle is too low. You can remove the version of pycodestyle from the requirements.txt file

@huan
Copy link
Member

huan commented Feb 29, 2020

Thanks for the fix!

However, in order to pass the CLA, I believe you need a force push, or close this PR and re-submit it to clean the previous commit with the wrong email address.

@wj-Mcat wj-Mcat closed this Feb 29, 2020
@huan
Copy link
Member

huan commented Feb 29, 2020

merge to #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants